Update flamed enemies with an overlay like ice (rebased) #3242
Conversation
|
imma test this |
src/badguy/badguy.cpp
Outdated
| @@ -173,9 +188,21 @@ BadGuy::draw(DrawingContext& context) | |||
| } | |||
| else | |||
| { | |||
| if (m_frozen && is_portable()) | |||
| if (m_frozen && is_portable()) { | |||
There was a problem hiding this comment.
| if (m_frozen && is_portable()) { | |
| if (m_frozen && is_portable()) | |
| { |
src/badguy/badguy.cpp
Outdated
| if (m_state == STATE_BURNING) { | ||
| // draw the flame sprite | ||
| m_firesprite->draw(context.color(), draw_pos, m_layer); | ||
| } | ||
| else { | ||
| /*m_firesprite->set_frame(0); | ||
| m_firesprite->pause_animation();*/ | ||
| } |
There was a problem hiding this comment.
| if (m_state == STATE_BURNING) { | |
| // draw the flame sprite | |
| m_firesprite->draw(context.color(), draw_pos, m_layer); | |
| } | |
| else { | |
| /*m_firesprite->set_frame(0); | |
| m_firesprite->pause_animation();*/ | |
| } | |
| if (m_state == STATE_BURNING) | |
| { | |
| m_firesprite->draw(context.color(), draw_pos, m_layer); | |
| } |
There was a problem hiding this comment.
still has the same issue as last time, that being..
https://github.com/user-attachments/assets/1debf75e-41b9-4c98-8eeb-2818121e40d4
there also seems to be an issue with some enemy sprites randomly offseting. some enemies ive found to do this are
mr tree and stumpy + corrupted variants
igel
vicious icy and walking leaf + corrupted variants
snail + corrupted variant
corrupted jumpy
the swimming fish + varitants, chasing fish + variants, skullyhops, pumpkin and bumpkin, leafshot + corrupted variant, owl, wooden jumpy, zeekling, corrupted igel, and jumping fish all do not have the offset issue seemingly.
also, the forest chasing fish will turn into the icy island chasing fish while burning.
|
also shouldnt we get a water slash overlay for snow enemies? as i doubt theres gonna be unique melting animations drawn for them all. |
|
I fixed the weird offsets, hopefully. Melting animations would be nice to have but let's leave it for a different PR. Maybe a water splash animation would do the job. |
|
would test but all the builds are failing |
Graphics are by @Rusty-Box !
Hypernoot
force-pushed
the
fireoverlay-hypernoot
branch
from
463b8ea to
490e4f4
Compare
|
For melting animations, I suggest just changing the colour to blue and call it a day. |
a successor of #3133